search

chrislo27 / PolyrhythmMania

A game that faithfully recreates the Polyrhythm minigame from Rhythm Tengoku (リズム天国), with a built-in level editor
https://polyrhythmmania.rhre.dev
GNU General Public License v3.0
246 stars 19 forks source link

[Bug]: Audio Mixer setting does not effect menu sfx #7

Closed BobTheNerd10 closed 3 years ago

BobTheNerd10 commented 3 years ago

Version

v1.0.0

Operating System

Windows 10

Problem Description

Title is pretty self explanatory, changing the audio mixer setting has no effect on menu sounds. This includes mousing over menu options, entering menus, exiting menus, and also pausing the game (Pause menu navigation sfx are also effected) Game sounds seem to be unaffected (Not including pausing)

Steps to Reproduce Problem

Requirements: Multiple audio mixers are required

  1. Change the audio mixer setting to a mixer setting that either isn't used or plays sound at a different location
  2. Listen as some sounds and music play through one source while the menu sounds play through another

Relevant log output

No response

(Optional) Other useful information

No response

chrislo27 commented 3 years ago

This is technically intended behaviour but it's not very clear in-game as to why the mixer settings exist and why they behave like they do.

The mixer settings are from an old RHRE issue chrislo27/RhythmHeavenRemixEditor#337 where the default mixer output was being set to something not correct. The mixer settings only affect gameplay music+SFX and the main menu music. All other sounds use OpenAL and have no mixer settings.

Generally, it is easier for me to play a quick sound through like a menu sound OpenAL. Game music and SFX are mixed together in the mixer because they have to be synced, whereas the pause menu SFX don't have to be synced. Also, it would be hard to play pause menu SFX if the game (and thus the mixer-based audio engine) is paused!

Lastly, the main menu music uses features only available in my mixer-based audio engine.

The solution to this problem would be to either move mixer settings to an advanced audio menu of some kind so it doesn't get tampered with unnecessarily, or to move all OpenAL sounds to use a mixer. The latter is cleaner overall but anything of the sort will be low priority.

BobTheNerd10 commented 3 years ago

Ohh, ok Thanks for clarifying! Subjectively, I think that an option for where the menu sounds should output would be helpful. For now I'll close this issue

chrislo27 commented 3 years ago

Mixer settings have been moved to an Advanced Audio settings menu with some information on what it affects, for next patch release. 59ae63ee61740da40aee96e220a90ac4cc994c30