search

chrislusf / glow

Glow is an easy-to-use distributed computation system written in Go, similar to Hadoop Map Reduce, Spark, Flink, Storm, etc. I am also working on another similar pure Go system, https://github.com/chrislusf/gleam , which is more flexible and more performant.
3.2k stars 248 forks source link

Make test compile #20

Closed alpe closed 8 years ago

alpe commented 8 years ago

Minor changes in test code to make them compile and green. data_store_test:TestReadOffsets is deactivated as it is constantly failing with deadlocks. I don't think the test setup is correct. Please correct me if I'm wrong but I couldn't find anything writing to the store for the test.

alpe commented 8 years ago

Still some data races left to fix. Will do a new PR.

chrislusf commented 8 years ago

Thanks! I applied your PR and removed the outdated test.

chrislusf commented 8 years ago

Do you have any idea how to fix for the "go test -race"?

alpe commented 8 years ago

I haven't looked into the details, yet but I hope I can find some time soon.

alpe commented 8 years ago

@chrislusf I've had a quick look and already identified some shared resources. I did some patches in my https://github.com/alpe/glow/tree/race_conditions branch. Please don't merge/ copy them yet. I'd like to finish a proper PR. :-) I've started using simple sync locks. If some of the code is more performance critical we may do benchmarks and use better algorithms.