http server address and port should be configurable

chrislusf / glow

Glow is an easy-to-use distributed computation system written in Go, similar to Hadoop Map Reduce, Spark, Flink, Storm, etc. I am also working on another similar pure Go system, https://github.com/chrislusf/gleam , which is more flexible and more performant.

3.2k stars 248 forks source link

http server address and port should be configurable #23

Closed alpe closed 8 years ago

alpe commented 8 years ago

In https://github.com/chrislusf/glow/blob/master/driver/rsync/http_server.go#L91 is a random port selected which makes it very hard when access is restricted via firewalls or in a container environment where ports are exposed. The remote address which is used with the heartbeat can be a local one. Then it's impossible for any client outside to connect. I had these problems when I tried to connect to a local docker cluster from the host system.

chrislusf commented 8 years ago

this was actually on my to do list. Do you want to pick it up? Just make the port number default to 0. Just let me know if it involves too much changes.

alpe commented 8 years ago

@chrislusf This isn't a blocker for me at the moment. I just wanted to make a note to not forget about it.

chrislusf commented 8 years ago

fixed now.