search

chrislusf / glow

Glow is an easy-to-use distributed computation system written in Go, similar to Hadoop Map Reduce, Spark, Flink, Storm, etc. I am also working on another similar pure Go system, https://github.com/chrislusf/gleam , which is more flexible and more performant.
3.2k stars 248 forks source link

Add localhost to network address. #51

Closed justicezyx closed 8 years ago

justicezyx commented 8 years ago

This fixes the 'unreachable network' error during the test.

justicezyx commented 8 years ago

The test timeout seems too short. Will submit anyway.

chrislusf commented 8 years ago

I actually did not notice that you revert this commit before. Just revert it if my merge is not appropriate.

justicezyx commented 8 years ago

Thanks Chris, I think this test should be fine now.

I removed network_util_test.go because there is several places in the test code that cause flakiness, or fail constantly inside the travis CI.

This PR (pull request) only fail in travis CI because of timeout. You mentioned in the other PR timing out is not due to the code running too slow. Then there is no known issues for this change.

Sorry for the churns in the change history. I will follow the workflow:

  1. local change
  2. pull request + travis test
  3. merge For all of my following tests changes.