search

chrism0dwk / wuhan

Modelling of the nCoV-2019 outbreak in Wuhan, China, by Jon Read, Jess Bridgen, and Chris Jewell at Lancaster University.
74 stars 19 forks source link

Typos in README.md #2

Closed chrism0dwk closed 4 years ago

chrism0dwk commented 4 years ago

From: Luca Brugnolini Luca.Brugnolini@rokoscapital.com Sent: 28 January 2020 13:27 To: Read, Jonathan jonathan.read@lancaster.ac.uk Subject: RE: [External] Paper data Novel coronavirus 2019-nCov

Thanks a lot for the answer,

This is probably also the reason why I get an error with dimension mismatch using the package, as in the example max_t is set to 22 but china_cases.R and world_cases.R still contain 24 days – thus assertthat::assert_that(all(dim(y_prime) == dim(exp_incr_prime))) fails. While if I put 24 or reduce the dataset in the package it works.

Also, just to flag, in the example on github you have

> p_hat[1:3] = exp(p_hat[1:3])
> p_hat[4] = exp(p_hat[4])

However p_hat is a list containings also $value and $counts beside $par, so I believe this should be p_hat$par – as likely also in the bootstrap function, but I didn’t check that

> samples = bootstrap(p_hat, K, W, alpha=1/4, max_t=22, n_samples=1000)

Hope this may help,

Best

Luca

chrism0dwk commented 4 years ago

Many thanks Luca for picking up the typos in the README file. These have been corrected in #fa1bbf7.