chrism2671 / PyTrendFollow

PyTrendFollow - systematic futures trading using trend following
MIT License
378 stars 74 forks source link

Base Currency different than USD #31

Open jerreyz opened 6 years ago

jerreyz commented 6 years ago

Hi everyone,

I tried changing the base currency to EUR but keep getting an error that prices are not found for USDEUR. I simply added a dictionary with codename USDEUR and then changed the lambda x:x to lambda x: 1/x. as said in the guide. Ideally the code could figure out concurrent currencies by triangular multiplication or inverting.

chrism2671 commented 6 years ago

Did you check that said prices are actually downloaded? Unfortunately Quandl has recently retired its WIKI currency price database, which is a real frustration.

On 21 May 2018 at 15:24, Jeroen De Ryck notifications@github.com wrote:

Hi everyone,

I tried changing the base currency to EUR but keep getting an error that prices are not found for USDEUR. I simply added a dictionary with codename USDEUR and then changed the lambda x:x to lambda x: 1/x. as said in the guide. Ideally the code could figure out concurrent currencies by triangular multiplication or inverting.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chrism2671/PyTrendFollow/issues/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AAb3XfpragBX0OwnuWk7sEmH6-w0nFR5ks5t0s4VgaJpZM4UHEmt .

--

Chris MuktarDirector Email chris@wikijob.co.uk chris@wikijob.co.uk

Switchboard 0845 625 9454 Website www.wikijob.co.uk http://www.wikijob.co.uk/ 101 Finsbury Pavement, London, EC2A 1RS http://wikijob.co.uk/

jerreyz commented 6 years ago

Hey Chris, you are correct, no prices have been downloaded. Could you explain how prices/currencies are downloaded exactly because I only see calls being made to the functions in data_feed and not to the Provider classes. Thanks in advance

chrism2671 commented 6 years ago

Normally it downloads everything you need when you download the contract.

The functions to download stuff are in quandl_provider.py. There's a script (download.py) that should download everything too.