search

chrismair / GrailsCodeNarcPlugin

Grails CodeNarc plugin
Apache License 2.0
10 stars 5 forks source link

implements 'excludes' property #3

Closed yuki-takei closed 10 years ago

yuki-takei commented 10 years ago

These changes adds 'excludes' property that can be declared in BuildConfig.groovy.

Usage:

codenarc.excludes = [
    '**/Dummy*.groovy',
    'grails-app/taglib/**/Some*TagLib.groovy'
]

There is a difference in the implementation of 'extraIncludeDirs' and 'excludes'. One specifies directories, the other specifies paths. Considering affinity to ant task, I think it's better.

Or, we may need to also implement 'includes' property.

Such as:

codenarc.includes = [
    'grails-app/taglib/**/Some*ExceptThisTagLib.groovy'
]
chrismair commented 10 years ago

Thanks for the contribution. I like it.

I've never been especially happy with the existing "includes" mechanism/syntax.

chrismair commented 10 years ago

I just released v0.21 of the Grails CodeNarc plugin, including this enhancement.

yuki-takei commented 10 years ago

Good Job!