chrismaltby / gb-studio

A quick and easy to use drag and drop retro game creator for your favourite handheld video game system
https://www.gbstudio.dev
MIT License
8.54k stars 471 forks source link

GB Studio crashes when playing mod file #1225

Open nlhomme opened 2 years ago

nlhomme commented 2 years ago

Describe the bug When playing a music (.mod file), BG Studio crashes with this error:

Uncaught TypeError: Cannot read property 'note' of undefined

file:///Applications/GB%20Studio.app/Contents/Resources/app.asar/.webpack/renderer/vendor-scriptracker/index.js:L2598C:33

To Reproduce Steps to reproduce the behavior:

  1. Create an empy project
  2. Go in the music view and enable .mod music format
  3. Import a mod file (I used the French National Anthem from the community)
  4. After select "France Intro"), hit the play button

Expected behavior The French National Anthem occurs

Screenshots image

Platform (please complete the following information):

Additional context The problem occurs no matter the mod file imported

zeus86 commented 1 year ago

this happens to me as well on every mod-file from the community-repo, which is really frustrating. running gb-studio 3.1.0 on Ubuntu 20.04 x86_64 (git:2057d7d0)

zeus86 commented 1 year ago

By the way, i found out whats going wrong here, and i think you can close the issue. The GB-Studio-Community-Assets Project moved their Tracker files to git-lfs, because of Line-Ending-Problems when downloading zipped files. However, if you don't have git-lfs isntalled, and clone the repo, you will get dummy-text-files with an git-lfs-hash, instead of the actual modfiles. GB-Studio cannot play them, because they aren't modfiles.

Solution: Install git-lfs and clone the repo again.

...however, a nicer error-message would be very appreciated...

Sneekypops commented 1 year ago

This was my problem. Thank you. Had no idea LFS did this.

zeus86 commented 1 year ago

This was my problem. Thank you. Had no idea LFS did this.

you're welcome. me neither. This confused me more, than it should have :)

zeus86 commented 1 year ago

btw, i am pretty sure, this issue can be closed...