search

chrismaltby / gb-studio

A quick and easy to use drag and drop retro game creator for your favourite handheld video game system
https://www.gbstudio.dev
MIT License
8.38k stars 465 forks source link

Clicking on the effect column in tracker mode seems to freeze GB Studio 4 Beta 1. #1409

Closed Amixofwordscombinedtomakeausername closed 3 months ago

Amixofwordscombinedtomakeausername commented 3 months ago

Describe the bug In the current beta build of GB Studio 4, I've encountered a bug where entering tracker mode in the music editor and clicking on the effect column would freeze GB Studio until I close out of the program.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Music'
  2. Click on any song
  3. Enter tracker mode
  4. Click on the effect column
  5. See Bug

Expected behavior Clicking on the effect column in tracker mode shouldn't freeze GB Studio.

Platform (please complete the following information):

Additional context This issue was absent in previous versions of GB Studio.

pau-tomas commented 3 months ago

Investigating, seems like the first change where this broke is 16d252d1704b62b82f5e033aecda7fbad52fc001

pau-tomas commented 3 months ago

Thanks for reporting @Amixofwordscombinedtomakeausername ! I think I fixed the issue with https://github.com/chrismaltby/gb-studio/pull/1411, will ping you once it merges and can be tested

gregtour commented 3 months ago

Thanks Pau!!