chrismattmann / imagecat

ImageCat is an Apache OODT RADIX application that uses Apache Solr, Apache Tika and Apache OODT to ingest 10s of millions of files (images,but could be extended to other files) in place, and to extract metadata and OCR information from those files/images using Tika and Tesseract OCR.
94 stars 40 forks source link

Fix bug in installation script #41

Closed Coldsp33d closed 6 years ago

Coldsp33d commented 6 years ago

@chrismattmann

Professor, This PR references issue #40. There is a bug in the script that prevents the "--OODT_HOME--" placeholder substrings from being appropriately replaced by the correct path.

The changes are made to install.sh. Furthermore, for sed to work on Darwin machines, the -i parameter must be updated to include a backup file extension, without which sed will not run. I have added a fix for this as well.

Additionally, we can edit the "Automated Install" portion of the readme - the installation scripts have rendered some of these steps redundant. I can include a doc fix as a part of this issue itself.


Shiva Deviah (Team 6)

chrismattmann commented 6 years ago

Thanks!!

Coldsp33d commented 6 years ago

@chrismattmann Thank you professor. Additionally, may I propose the following updated list for the Automated Installation process?

  1. Navigate to desired location for imagecat
  2. git clone https://github.com/chrismattmann/imagecat.git
  3. cd imagecat
  4. cd auto
  5. chmod +x install.sh
  6. ./install.sh
  7. Wait for a install to finish
  8. cd ../../deploy
  9. Add the absolute paths of all images (one image path per line) in data/staging/roxy-image-list-jpg-nonzero.txt
  10. ./start.sh
  11. ./bin/chunker
  12. win

From my experience, only these steps are necessary to successfully setup imagecat.

PS: I also think we can remove the manual installation guide altogether - the manual steps are just picking apart ./install.sh and ./start.sh and doing everything manually, which seems unnecessary!

chrismattmann commented 6 years ago

Yes can you update that?