search

chrismccord / mailgun

Elixir Mailgun Client
MIT License
194 stars 95 forks source link

testing mode for writing mails to a file instead of sending them #4

Closed manukall closed 9 years ago

manukall commented 9 years ago

I added an option for mailgun to output mails to a local file instead of actually sending them. I use that for integration testing a single page app, where the tests are run by another process.

chrismccord commented 9 years ago

Looks great! I have just one small comment

manukall commented 9 years ago

I pushed the changes. Thanks for reviewing so quickly.

chrismccord commented 9 years ago

Let's make the mode :test instead of :testing and think this is ready to go

manukall commented 9 years ago

do you want the testing_file_path to become test_file_path then, too?

chrismccord commented 9 years ago

yes please

On Mar 6, 2015, at 11:21 AM, manukall notifications@github.com wrote:

do you want the testing_file_path to become test_file_path then, too?

— Reply to this email directly or view it on GitHub https://github.com/chrismccord/mailgun/pull/4#issuecomment-77586803.

manukall commented 9 years ago

ok, changed those.

chrismccord commented 9 years ago

<3 <3 <3