search

chrismiles / CMPopTipView

Custom UIView for iOS that pops up an animated "bubble" pointing at a button or other view. Useful for popup tips.
https://github.com/chrismiles/CMPopTipView
MIT License
2.74k stars 466 forks source link

iOS 11 Bugfix: Find the correct container-view when a poptip is prese… #128

Closed parallaxe closed 7 years ago

parallaxe commented 7 years ago

In iOS 11, the view-hierarchy of UINavigationBars changed. Thus, the poptip and button to dismiss is not added on the superview of the UINavigationBar, but on the UINavigationBar instead. This patch traverses the superviews of the UIBarButtonItem-view and tries to find the UINavigationBar and chooses its superview.

kleinlieu commented 7 years ago

Thanks! @parallaxe Is this backwards compatible with versions under iOS 11?

parallaxe commented 7 years ago

Yes, i tested it with iOS 9 and in general, it should be backwards compatible with all versions.

kleinlieu commented 7 years ago

Thanks for the fix!