chrismiles / CMPopTipView

Custom UIView for iOS that pops up an animated "bubble" pointing at a button or other view. Useful for popup tips.
https://github.com/chrismiles/CMPopTipView
MIT License
2.73k stars 467 forks source link

Radius takes over Padding #52

Open Joshua4550 opened 11 years ago

Joshua4550 commented 11 years ago

Upon adding these two parameters (just like the demo suggested): popTipView.cornerRadius = 2.0; popTipView.sidePadding = 30.0f;

The Radius works fine, however because the radius is so low, the desired padding is ignored (or not taken into consideration properly) as there is still next to no padding. The code given should produce a padded (almost) square bubble, but it gives a non-padded square bubble instead.

Sorry if this was intentional and I've got the wrong end of the stick!

Other than this, this subclass is great - thank you very much for providing it.

veptune commented 11 years ago

I got exactly the same problem ;(

Can someone fix it please ?

Thanks guys :)

chrismiles commented 11 years ago

This looks to be working for me. The attached image is a capture with

popTipView.cornerRadius = 2.0;
popTipView.sidePadding = 30.0f;

The corners are almost square, and the bubbles are positioned away from the edge of the container view (the padding).

Is this not what you are seeing?

2013-10-14 12 16 25 pm

veptune commented 11 years ago

Hmm ... if i put 30.f as sidePadding i got something but when i want to increase the value let's say 50.f or 80.0f, the padding look the same

chrismiles commented 11 years ago

If there is not enough room to apply the padding then it is reduced. The above examples worked for me. They are more visible when the demo is rotated to landscape. In portrait there's not enough room for large side padding values.

Odelya commented 11 years ago

Hi Chrismiles and thanks for the component.

I have the same problem with a custom view:

popTipView.cornerRadius = 0; popTipView.sidePadding = 0; popTipView.topMargin = 0; would result like this: screen shot 2013-10-29 at 5 38 58 pm

While

popTipView.cornerRadius = 10; popTipView.sidePadding = 0; popTipView.topMargin = 0;

Would result like this: screen shot 2013-10-29 at 5 38 39 pm

I would like to have round corners but not padding. This way, the poptip will have round corners and the customview will be "clipped" to have as well

SjoerdPerfors commented 11 years ago

I think we talk here about different paddings.

1) padding from the screen where the balloon should appear. (this is what sidepadding is doing) 2) padding in the balloon where the text should appear. (can we change this?)

After adjusting the cornerRadius my padding in the balloon is adjusted to a lower margin/padding value (point2).

fawazapp commented 8 years ago

this work for me CMPopTipView *popTipView = [[CMPopTipView alloc] initWithMessage:@"A Message Text"]; popTipView.cornerRadius = 2.0; popTipView.bubblePaddingY = 5; popTipView.bubblePaddingX = 5; popTipView.shouldEnforceCustomViewPadding = YES; [popTipView presentPointingAtView:ContainerView inView:self.view animated:YES];