search

chrismwilliams / astro-theme-cactus

A simple Astro theme. Use it to create your blog or website.
https://astro-cactus.chriswilliams.dev/
MIT License
866 stars 132 forks source link

Fix Default Selector for Code Themes #256

Closed nhtsai closed 4 months ago

nhtsai commented 4 months ago

What kind of changes does this PR include?

Description

Fixes a typo in the default theme selector for code syntax highlighting.

netlify[bot] commented 4 months ago

Deploy request for astro-theme-cactus rejected.

Name Link
Latest commit f5d79ff7e3cd5bc06a569dc23b171ac21e92ecf9
chrismwilliams commented 4 months ago

Hey @nhtsai, I'm not sure if you're having issues with this but in testing I don't see what this changes/fixes. The theme closely follows Starlight's config which the maintainer of expressive-code created, and also the default for expressive-code, so I'm not sure what's wrong?

nhtsai commented 4 months ago

Hey @chrismwilliams, I was trying to keep one code theme for both light and dark modes, but it looks like it was an issue on my end. I'm completely new to web dev, so I appreciate you providing some context to learn more, thanks! Closing this PR now.