chrismwilliams / astro-theme-cactus

A simple Astro theme. Use it to create your blog or website.
https://astro-cactus.chriswilliams.dev/
MIT License
866 stars 132 forks source link

fix(layout/BlogPost): content full width when ToC hidden #268

Closed hamzab-01 closed 1 month ago

hamzab-01 commented 1 month ago

What kind of changes does this PR include?

Description

before (when screen small enough for ToC to be hidden, there is a gap where the ToC was shown previously) after (content now max width)
image image
before (when screen large, ToC shown) after (no change)
image image
netlify[bot] commented 1 month ago

Deploy request for astro-theme-cactus rejected.

Name Link
Latest commit 01827199fc2a7602c31b836067ded31c6ca84258
chrismwilliams commented 1 month ago

Thanks @hamzab-01 for the detailed pr, its really helpful when returning to the project.

For this I think I'm going to keep it as-is and leave it up to the user to change, just because of the expectation of using .prose, plus I'd likely have to mirror @tailwindcss/typography prose class going forward, if it were to change. There can also be inconsistancies using ch values when working with multiple fonts, which some users may face.

My suggestion, if this is something you're adding to your own project, would be to just disable the max-width (as per their README) and apply any width(s) to the container.