Fixed #2 - Githubissues

chrisosaurus commented 9 years ago

@phillid thanks again for your interest.

What happens if we hit EXIT in the case of an error? we cannot guarantee that p.start is non-null, and so the deref now->next could be deref of a null pointer.

Some changes I would appreciate:

consideration of the above mention error case
commit message explaining what you are fixing (as currently it has no meaning without github)
initialising those two new variables to 0 (defensive programming), and one variable per line (trying to keep a consistent style)
a comment above the cleanup block explaining what you are doing.

You can make changes, add them and (git add), then ammend your commit (git commit --amend), and then force push (git push --force origin master:master) which will update this PR.

phillid commented 9 years ago

@mkfifo, thanks for the hint, I hadn't noticed that, all fixed

chrisosaurus commented 9 years ago

@phillid thanks for that, looking good!

chrisosaurus commented 9 years ago

@phillid just noticed that some tabs snuck in around the indenting of the comment characters https://github.com/mkfifo/dodo/pull/3/files#diff-1c67fed3903b9b87e70ec8f7e94f090fR943

I have pushed a commit to strip these.

Thanks again!

chrisosaurus / dodo

Fixed #2 #3