search

chrisprice / phonegap-build

This project aims to provide a stand-alone Java API for communicating with the PhoneGap Build REST API and a Maven Plugin which makes use of the API to turn WAR projects into binaries for mobile platforms.
http://chrisprice.github.com/phonegap-build/phonegap-build-maven-plugin
Apache License 2.0
11 stars 18 forks source link

Possibility to configure the intermediate zipFile. #12

Closed rabahi closed 11 years ago

rabahi commented 11 years ago

BEFORE:

NOW:

Regards,

buildhive commented 11 years ago

Chris Price » phonegap-build #47 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

Chris Price » phonegap-build #48 SUCCESS This pull request looks good (what's this?)

chrisprice commented 11 years ago

This looks like a nice little feature to add, thanks @cousiano for taking the time to do such a rigorous job of it!

One comment - I'm a bit of a whitespace nazi, it would be great if you could match the standard (in the loosest sense of the word) of the rest of the file. If you've not got time to do this, don't worry I can do it but I won't have a chance for a couple of weeks.

Also, do you mind me asking what your use case for this is?

P.S. Sorry for not commenting earlier, I've been on holiday.

buildhive commented 11 years ago

Chris Price » phonegap-build #49 SUCCESS This pull request looks good (what's this?)

rabahi commented 11 years ago

Hi @chrisprice,

Hope you had great holydays :)

I updated the whitespace. I hope it is what you expected.

I build my "phonegap" project using Jenkins. In my Jenkins project home page, i want to have direct link access to the artifacts: myproject.zip, myproject.apk, myproject.ipk, etc... (so i need that all the artifacts have the maven build final name). For information, myproject.zip (old file.zip) is included in a webapp.

Do not hesistate if you want more informations :-)

Regards,

buildhive commented 11 years ago

Chris Price » phonegap-build #50 SUCCESS This pull request looks good (what's this?)

chrisprice commented 11 years ago

I've pushed 0.0.5, hopefully it'll show up on central sometime soon. Thanks!