Sync update check bug

[chrisputnam9]

To replicate:

1. Browser 1, remove item
2. Browser 2, remove item
3. Browser 1, sync
4. Browser 2, sync
5. Refresh browser 1 - missing changes but sync not recommended

[chrisputnam9]

The issue is because we are checking remote update against local sync

• In step 3 above, we sync b1 after b2 makes an update
• So, then in step 5, even though remote has now been updated by b2, b1 sees that it's sync happened after remote updated

Might be as simple as always comparing by sync time, eg:

• If local updated since last local sync, need a sync
• If remote synced since last local sync, need a sync
• No longer care about remote updated - because it could throw us off

[chrisputnam9]

The problem is, this results in a sync cycle:

1. Browser 1 now shows updates on refresh, so we sync
2. But now, Browser 2 will show updates on refresh - because sync time has changed from step 1
3. So, we sync Browser 2, but now Browser 1 shows updates, and so on.

Instead, maybe we can:

1. Keep using updated_at
2. When syncing, compare JSON strings to see if anything actually is changing
3. If things are changing either in local or remote, then set updated_at to current time
4. Otherwise, leave it as is

[chrisputnam9]

Set up - need to test more

[chrisputnam9]

Need to reduce API calls - shouldn't hit API every time a change is made in config...

• If we already know we need to sync - there's no need to keep checking until after a sync is done
• Maybe go back to caching remote updated_at and clear it when a sync is done

[chrisputnam9]

Looking good - a bit more testing then launch