chrisquince / DESMAN

De novo Extraction of Strains from MetAgeNomes
Other
69 stars 22 forks source link

conda install #22

Closed JChristopherEllis closed 6 years ago

JChristopherEllis commented 6 years ago

Any plans to get this into conda for a one click install?

meren commented 6 years ago

I am jumping in, I hope Chris doesn't mind:

There is currently an effort to convert the codebase to Python 3, and we will be happy to also make installation and utilization of the tool much more easier.

Thanks!

JChristopherEllis commented 6 years ago

Awesome, great news and thanks for the quick reply. When do you think that will be completed?

Thanks again!

meren commented 6 years ago

My colleagues (Ozcan Esen and Evan Kiefl) finished converting the codebase to Python 3, and confirmed everything is working. They will soon send a pull request for Chris to investigate. Once the codebase is settled, and Chris is happy, we can work on an easy installation scenario.

While I am not comfortable giving an estimate on others' behalf, I don't think it would take a lot. That said, I am not sure if we can deliver that in less than 2 weeks, since there is always another 10 things to do on the side :)

Best wishes,

JChristopherEllis commented 6 years ago

I know how that goes all too well. Things always take longer than expect.

God Speed Meren! :)

JChristopherEllis commented 6 years ago

Hi Meren,

Excited to install/use Desman with conda install. Do you still think it will be completed soon?

meren commented 6 years ago

Good reminder :) Thank you!

@chrisquince, we want to deliver this, but we need to have a tagged version of the master repository.

do I have your permission to tag the current master as v2.0? or if you have anything minor to add to/remove from the current master we can wait for that.

Best,

chrisquince commented 6 years ago

Hi Meren,

There are a few minor python3 fixes in the scripts that need committing first. I will add those to the current master later on today and let you know when it is ready to tag.

Thanks, Chris

chrisquince commented 6 years ago

Hi Meren,

You can tag it now @meren, I ran through the complete example and debugged all the scripts in python3!

Thanks, Chris

meren commented 6 years ago

Done! Thank you, @chrisquince. There will be a brew package for this tagged version very soon.

JChristopherEllis commented 6 years ago

and a conda package for us conda users? Too much too soon? :)

meren commented 6 years ago

Let's go step by step. Once there is a brew package, conda will be rather straightforward I presume.

johnne commented 6 years ago

Hi all, I've been working on getting desman ready for use in a snakemake workflow I'm using. As part of that I've also taken the first steps to add a desman recipe to the bioconda channel. Please see PR #26.

All the best, John

meren commented 6 years ago

Excellent, John! Thanks for this :)

johnne commented 6 years ago

No problem :). If you add a release for the latest merge I will update the bioconda recipe and make a pull request to have it added to the channel.

chrisquince commented 6 years ago

Hi John, I have created a new version 2.1 of that merge after checking the complete example again. I need to automate that!