search

chrisquince / STRONG

Strain Resolution ON Graphs
MIT License
46 stars 9 forks source link

merge_bin.py fail on creating symlink #65

Closed Sebastien-Raguideau closed 5 years ago

Sebastien-Raguideau commented 5 years ago

Though it should not be rerun in this case. I'll still fix that by checking first that the symlink does not exist.

Sebastien-Raguideau commented 5 years ago

So, not just on rerun, on simple run too.It seems it creates a folder beforhand and fail to create symlink since a folder already exist there.

Sebastien-Raguideau commented 5 years ago

ok, so issue is that all bins, be they to merge or not, have a folder created before. Then os.symlink fail because the folder exist already. Just to say but os.system("ln -s ") wouldn't fail here.

chrisquince commented 5 years ago

Hmm... maybe use os.system("ln -s ") then?

Sebastien-Raguideau commented 5 years ago

I added an if condition so that only merged bin have a folder created and it works.

Sebastien-Raguideau commented 5 years ago

Well turn out there was no issue, I just had an error somewhere in my code before that...