search

chrisreedio / socialment

Socialite OAuth Support for Filament
MIT License
73 stars 10 forks source link

Added post socialite hook and updated README #38

Open josh48202 opened 6 months ago

josh48202 commented 6 months ago

added post socialite hook for additional socialite validation and updated to match recent updates.

chrisreedio commented 6 months ago

@josh48202 I haven't forgot about this!

I'm completely swamped with work right now.

The good news is we're using Socialment in the project and it should be coming to a close in the first few weeks after the new year.

This should really allow me to give the new functionality a run for it's money and battle test it.

I am planning on getting this code in hopefully sooner rather than later.

Thanks again for submitting this and I do plan to get it in. Just wanted to let you know I hadn't forgotten about you!

josh48202 commented 3 months ago

loving all the new updates. just checking in on this.

chrisreedio commented 2 months ago

Hey @josh48202, lets catch up on this.

I reviewed this and wanted to get your thoughts on how I've implemented this in another 'glue' package I use on a few sites.

https://github.com/chrisreedio/socialment-bastion-azure/blob/3.x/src/SocialmentBastionAzureServiceProvider.php#L144

Here I do some checks to see if the user attempting to login can 'access the application'.

I've wanted to do a kind of 'plugin/addon' system for this package to enhance the functionality of specific drivers while keeping driver specific code out of the code.

Would love to hear any thoughts you have on this.

Also appreciate the kind words!