search

chrisreedio / socialment

Socialite OAuth Support for Filament
MIT License
73 stars 10 forks source link

(fix): typehint #42

Closed pepperfm closed 2 months ago

pepperfm commented 3 months ago

Hi there!

Here ive got an error, when trying to pass closure as parameter.

May be here should be inversed changes? (remove callable type from method params, not from properties)

chrisreedio commented 3 months ago

Can you explain these changes @pepperfm ?

You should have already been able to pass in a closure.

pepperfm commented 3 months ago

You should have already been able to pass in a closure.

function can accept the closure, right but the class properties is only can be string or null: protected ?string $loginRoute = null;

so when i trying to pass closure, ive got an error

pepperfm commented 3 months ago

so when i trying to pass closure, ive got an error

on class-property level, not on function agrs