GitGud2018 commented 6 years ago

your script is doing it again had to disable it and add it in a roundabout manner also I find it sad, that you don't want to add my "Level top Heroes every X seconds code", had to manually add it again :/ why not just add it to the main script, you can just disable it by leaving the value at 0, if you don't like it

chrisreyn commented 6 years ago

1) how it runs for me is not the same as how it runs for everyone. Then turn #agree off if you're so bothered. i already fixed the missing #hitcount = 0 even before moving to my own repo. i just checked the code you sent in your issue before and i see nothing different from my code that could explain why you're experiencing this bug again. maybe you can show me how you fixed yours, that i can do

2) it was already in my code to just level the topmost heroes so i didnt think it was necessary to add yours especially if yours is set to run hero and skill lvl up every 60 seconds AND top hero every 30 seconds?? at the same time, maybe you'd want to lower your #runActionsEveryXSeconds 180; that IS too long for start of run. of course you'd have problems with portar stage skips and underleveled heroes with that

if you check :lvlTopHero, i already put a similar feature long long ago

//lvl up only nearby heroes at this time onwards
    if #minutes >= 4 or #lateRun > 0
        //slide down
        touchDown 1 280 740
        sleep 200
        touchMove 1 280 710
        sleep 50
        touchMove 1 280 500
        sleep 50
        touchMove 1 280 410
        sleep 50
        touchMove 1 280 400
        touchUp 1

        sleep 300
        #time = #time + 650

        goto :levelHeroesPressLevelUp
    endif

this is quite similar to what yours achieves.

3)

why not just add it to the main script, you can just disable it by leaving the value at 0, if you don't like it :/

because you cant copy paste into Nox anything more than 32 kB. If so, you need to do it in parts therefore requiring more time. Therefore, having unused features for me to put in my code (especially when it's already there) hassles me just so i have something that satisfies you

GitGud2018 commented 6 years ago

I turned off agree and just added a few clicks on the same coordinates into the press skill section, so it still periodically clicks that location when it checks for skill clicks your code just perma spams that area like it is trying to do a CQ, and I don't want that, because too many taps / second looks too supicious
yeah no, those are two completely different things your code just stops scrolling down all the way after some time to reduce the time it needs to do so and that is good too, I use that too but mine just quickly opens hero tab, levels each top hero once and closes it inbetween the big actionseveryXseconds rotation I don't have that set to 30 seconds, that's just a random value anyone can set however they want, I actually have it set to 10 seconds and it speeds up runs alot, because it keeps your top heroes as strong as possible all the time my actionseveryXseconds is set rather high, because it takes up alot of time, so I don't want it to do that often and also my Dimensional Shift is level 9, sometimes level 10, depending on what build I run, so my skill rotations just last that long
no idea what you mean with that just drag and drop the .txt file into nox and then move it into the hiromacro documents folder my script is 35.5KB in size and there is no issue copying it I always prepare the complete script outside nox and then just drag and drop the whole file into nox not for small changes, like changing some timers, but for big ones

edit: also, I am just trying to help by pointing out issues and making suggestions to improve the script for everyone, not just you or me everyone has to set their own time intervals for their options and if they don't like or want a feature, they can disable it, but it does not hurt you or me to provide that feature, because this makes the script more versatile and useful for more people

chrisreyn commented 6 years ago

@GitGud2018 see if it works (and if there are other quirks) before i roll the update out to the main branch. i just copied it from the code you posted before https://github.com/chrisreyn/Tap-Titans-2-Progress-Bot/blob/chrisreyn-SCpatch-4-30/SC%20PHoM%20(edit%20settings%20for%20CS)%20SEE%20UPDATE%20NOTES

im keeping my own agree/clanship/what have you on my code tho.

GitGud2018 commented 6 years ago

Alright, I tested it and this is what I noticed:

I think it spams "agree" because something is wrong in the random attack section, I am not sure why though - it correctly hits phom every 30 hitcount, but it ignores the hitcount for agree and just spams it if you have tapping activated, you won't mind that, but I have it deactivated to keep taps / second lower to prevent bot detection, but that is just my personal preferance, so I can just remove the agree part from the random attack section, no big problem :D
when you use laterun, it starts by scrolling the menu without opening the menu first, not sure if that is intentional, because you already have your menu open, when you start a late run?
top heroes extra leveling every X seconds works fine
stop leveling skills after X minutes works fine too

is this part in the skill press section correct? if #minutes < 16

colorRed = -1

    #colorBlue = 0
else
    getRGB #colorRed #colorGreen #colorBlue 410 705
    #time = #time + 100
endif

If I am getting this right, it should be > instead of <? to prevent it pressing skills until you actually have SC unlocked, in case it messed up during first skill leveling attempt. After minute 16 it has to assume SC is leveled now

but alltogether it seems to work great, it levels skills and heroes correctly, does CQ and prestiges, no problems there for me

chrisreyn commented 6 years ago

I'll see what i can do about that agree spam...

re: #lateRun, that's odd because it's not supposed to scroll at all and move directly to just heroes given the condition was

if #lateRun < 1 and #count < 2

Tho when i tested, yea, it does try to scroll still so... ???? EDIT: tried fixing it but no luck. tho it's not a big problem if it does this. it just runs against the logic but it's not a script breaking problem so i'll leave it as is for now

is this part in the skill press section correct? Yea, it's meant to not check if SC is running early in the run because manni mana appears then, therefore i should have enough mana. It should be the same logic even if you dont have SC maxed right off the bat right? or no?

GitGud2018 commented 6 years ago

oh well I changed it to >, because I prefer it to check for SC basically don't activate any skills and waste mana without having SC unlocked, so you definitely have enough mana to start the whole 5-skill rotation once SC is unlocked and leveled with just a few levels into the unskilled dmg artifact I can easily go the first 5 minutes of my run without using any skills, so I prefer it not to use any skills as long as it can't use all the skills it should then unlock sc in the next rotation of runactionseveryXseconds, if it failed in the first one I use sc phom, too and I max all the skills directly at the beginning, got some points in Mana Siphon and enough max mana + fluffers levels, so I can just keep up full rotations from beginning to end of run, if SC was unlocked and is being used :-)

but if the < is intentional, then I don't see any issues with the script, I can just keep it as > for my personal preference agree spamming and late run are both no big deal, the script looks pretty good at this point

chrisreyn / Tap-Titans-2-Progress-Bot

agree spamming #1

colorRed = -1