Code still does multiple commands even with them turned off.

Gorthul commented 5 years ago

Turning off leveling heroes or leveling skills or anything really doesn't do anything. The script still runs ands attempts all of the commands even if nothing is "on." I wouldn't mind much if either of those features worked at all but they don't. They get stuck in a scroll lock and don't actually level anything up.

I just want this to do clan quests for me. I don't even care that the heroes or skills leveling is broken. Just let me turn the features off that I don't want.

I am using Memu 5.5.5, I have set all of its and Hiro's settings correctly. I have downloaded the most update script. Nothing works.

Gufis22 commented 5 years ago

Same problems here. It's really weird how for some people these scripts work perfectly fine and for others they just loop and do nothing. I don't think you will get any help, since its really hard for the creators to replicate these issues if they are not having them. I've been struggling to find a working script for myself for almost 3 months now. :(

chrisreyn commented 5 years ago

does this happen on the Push script as well? If not, use that (tho idk if you want yours to prestige)

im a bit busy now to upload a new version for everyone. try doing this on the Adv Click script

look for this part:

:runActions
    #timeLastActionRun = #secondsTotal
    #actionStepper = #actionStepper + 1

    if #actionStepper == 2 and #enableSkills == 1 and  #skillsUnlocked < 6
        #skillsUnlocked = 0
        goto :openSwordMasterTab
    elseif #actionStepper == 1 and #enableHeroes == 1
        goto :levelHeroes
    elseif #actionStepper == 5 and #enableClanQuest == 1
        #actionStepper = 0
        goto :checkClanQuest
    else 
        #actionStepper = 0
        goto :checkBoss
    endif
goto :runActions

replace it with this:

:runActions
    #timeLastActionRun = #secondsTotal
    #actionStepper = #actionStepper + 1

    if #actionStepper == 2 and #enableSkills == 1 and  #skillsUnlocked < 6
        #skillsUnlocked = 0
        goto :checkClanQuest
    elseif #actionStepper == 1 and #enableHeroes == 1
        goto :checkClanQuest
    elseif #actionStepper == 5 and #enableClanQuest == 1
        #actionStepper = 0
        goto :checkClanQuest
    else 
        #actionStepper = 0
        goto :checkClanQuest
    endif
goto :runActions

if you noticed, i just changed the sword master tab, hero level and boss check into just the clan quest check so it should do nothing but check CQ

chrisreyn commented 5 years ago

might i also suggest to everyone having CQ unintentional multiple hits to add an extra 3 second sleep in this section

//touch clan icon bottom
    touchDown 0 100 730
    sleep #btnDelay
    touchUp 0
    sleep #loadingClanQuestDelay

just add a new line and put sleep 3000 below the 2nd sleep there

Gufis22 commented 5 years ago

The problem for me is that the push/advanced click doesn't even hit CQ's. Everything else works perfectly in the push script.

Gorthul commented 5 years ago

So I was just able to put the changes you recommended in place, and it still hits all skills at intervals, and will still try to auto prestige in 43 minutes regardless if that feature is turned on, or even if a different value is given in the line.

It certainly hits clan quests just fine, and since I'm really just leaving it active so it can clan quest for me while I'm asleep as long as I can figure out a way to turn off prestige it should work for my purposes.

chrisreyn commented 5 years ago

thats because skill usage is found in a different section namely :pressSkills. you can manually delete the touchPress for each skill activation

as for prestige, go to :checkPrestige and put goto :afterPrestige right after so all it does is reset everything from the start

if there are other things that you dont want it to do, just read the goto functions and redirect the appropriate code sections. variables/sections themselves have self explanatory names so you hsouldnt get lost much

ahben1997 commented 5 years ago

@chrisreyn can i ask if deleting TouchPress means that deleting the whole line for touch press ? For example Touch press 20 300 100, delete the whole Touch press ?

chrisreyn commented 5 years ago

@ahben1997 yes, delete by line, not by command

chrisreyn / Tap-Titans-2-Progress-Bot

Code still does multiple commands even with them turned off. #42