chrisrhymes / bulma-clean-theme

A clean and modern Jekyll theme based on Bulma
http://www.csrhymes.com/bulma-clean-theme/
MIT License
388 stars 491 forks source link

Bug: Not fixing the navbar forces light mode // Feature request: Use automatic dark mode per default, add option to enforce a specific theme #152

Closed GruberMarkus closed 6 months ago

GruberMarkus commented 6 months ago

The following code in /_layouts/default.html defines the class attribute twice:

    {% if site.fixed_navbar %}
        class="has-navbar-fixed-{{ site.fixed_navbar }}"
    {% endif %}
    class="theme-light"

Firefox ignores the second definition. This leads to the following problem:

Proposed solution:

    class="{% if site.fixed_navbar %} has-navbar-fixed-{{ site.fixed_navbar }} {% endif %} {% if site.force_theme %} theme-{{ site.force_theme }} {% endif %}"
GruberMarkus commented 6 months ago

By the way: Thank you very much for this theme! It is just great to be able to use bulma with Jekyll.