search

chrisrhymes / bulma-clean-theme

A clean and modern Jekyll theme based on Bulma
http://www.csrhymes.com/bulma-clean-theme/
MIT License
379 stars 478 forks source link

SASS build error on GitHub pages #157

Open martin-nc opened 1 month ago

martin-nc commented 1 month ago

Hi, we're suddenly getting a build error on our site: Rendering Markup: assets/css/app.scss github-pages 231 | Error: Invalid CSS after "... arrow($color: ": expected expression (e.g. 1px, bold), was "#{cv.getVar("li..." on line 4 Remote Theme: Cleaning up /tmp/jekyll-remote-theme-20240515-8-x5t49m Is this down to any recent changes? We haven't touched the SASS for a while. The code is here: https://github.com/elixir-europe/biohackathon-europe-2024.

Thanks!

chrisrhymes commented 1 month ago

Hi @martin-nc,

Please can you try setting your remote theme to v0.14.0 as per the readme and see if this resolves your error?

martin-nc commented 1 month ago

Hi @chrisrhymes great- that's fixed it! Sorry - I missed that update.

Incidentally, I added a couple of things to the theme in our instance:

  1. A "skip to content" link for accessibility. You can see this appearing at the top of the screen if you navigate the page using only the tab key: https://biohackathon-europe.org/.
  2. A sticky footer. Maybe this is more of a judgement call, but if you have a short page then it means the footer doesn't hang half-way down it on a large screen e.g. https://biohackathon-europe.org/programme/. I can create a PR for either of these if you're interested. The code might need tidying and abstracting so it works reasonably well in different contexts. Or perhaps you'd like to keep things simpler and leave it to the developer to implement stuff like that.

Thanks anyway!

martin-nc commented 1 month ago

Ah - now my override styles have gone, but I'll fix that.

chrisrhymes commented 3 weeks ago

Hello @martin-nc , sorry for the delayed response. The skip to content link sounds very useful if you have time to implement that in a pull request. Thanks.