Can't find stylesheet to import

chrisrhymes / bulma-clean-theme

A clean and modern Jekyll theme based on Bulma

http://www.csrhymes.com/bulma-clean-theme/

MIT License

388 stars 492 forks source link

Can't find stylesheet to import #158

Closed marcello-dev closed 6 months ago

marcello-dev commented 6 months ago

Hi,

Upgrading to v1 I get the following error:

The content of the file app.css is:

---
---
$primary: #F27100;
@import "main";

I have that file on my website because I changed the default color as mentioned in the doc.

Do you know what could be the issue?

chrisrhymes commented 6 months ago

Hi, I'm afraid I haven't seen this before. Maybe check what path is set for your sass source_dir in your _config.yml and if it is set to _sass where the _main.scss file is?

sass:
  style: compressed
  source_dir: _sass

marcello-dev commented 6 months ago

I don't have a path set for sass. This is my config.yml file: https://github.com/marcello-dev/marcello-dev.github.io/blob/feature/upgrade-to-bulma1/_config.yml

marcello-dev commented 6 months ago

I could fix it with this PR: https://github.com/marcello-dev/marcello-dev.github.io/pull/2/files And also by setting up Github Actions. But there are still some issues.

The font color of the Hero has always been white, but it changed to black (See below)

Do you have an idea how to fix the issue? I think the migration doc is very limited, please consider to add more info. Moving away from github-pages is not straightforward.

chrisrhymes commented 6 months ago

Glad you managed to get the upgrade sorted.

With regard to the hero text colour, this may be to do with Bulma v1's themes that have been introduced. There is some information in the upgrade guide to force using the light theme.

Please also see more information on the Bulma framework site as well regarding the dark mode. https://bulma.io/documentation/features/dark-mode/

For GitHub actions, I agree it is more complicated than using the previous method to deploy. What do you think needs to be added to the upgrade guide?

marcello-dev commented 6 months ago

The issue I am having is on the light mode. The dark mode seems fine.

chrisrhymes commented 6 months ago

I have been looking at the hero examples on the Bulma website and it looks like the black text is the desired behaviour in v1 of Bulma as most have dark text rather than white. This could be to improve colour contrast to meet accessibility guidelines.

marcello-dev commented 6 months ago

I see, thank you for checking. Can close the issue if you want.