search

chrisrhymes / bulma-clean-theme

A clean and modern Jekyll theme based on Bulma
http://www.csrhymes.com/bulma-clean-theme/
MIT License
383 stars 484 forks source link

Pagination current background color doesn't update with primary color #47

Closed philww241 closed 4 years ago

philww241 commented 4 years ago

The background color for the current page number in the blog index page (eg http://www.csrhymes.com/bulma-clean-theme/blog/) doesn't change with the rest of the site after changing the $primary color in app.scss. See screengrab below for an example.

This is not exactly a bug (even though the result looks odd), because it is a link and therefore correctly uses the $link color. The fix therefore is to add a new sass variable in app.scss to set the $link color: 

---
---
$primary: #333333;
$link: #333333;
// Import Main CSS file from theme
@import "main";

I thought it might be worth adding a note about this under 'Colours and Styles' in the readme.

image

chrisrhymes commented 4 years ago

Hello. I tried to leave the theme styling as minimal as possible. As you said, you can customise the link variable, or if you prefer you can specifically customise Bulma pagination variables as you need.

https://bulma.io/documentation/components/pagination/

philww241 commented 4 years ago

That's fair enough. I found the theme very easy to work with, it was just that one aspect that puzzled me until I figured out how to solve it.