search

chrisrhymes / bulma-clean-theme

A clean and modern Jekyll theme based on Bulma
http://www.csrhymes.com/bulma-clean-theme/
MIT License
387 stars 492 forks source link

support HTML lang tag #96

Closed casperdcl closed 3 years ago

casperdcl commented 3 years ago

A lang attribute is considered essential

chrisrhymes commented 3 years ago

Thanks for your pull request! Please can you change the below so there is a default lang for users that haven't set it in the _config.yml file. 

{% if site.lang %}
 lang="{{ site.lang }}"{% endif %}

to 

lang="{{ site.lang | default: 'en' }}"
casperdcl commented 3 years ago

Yeah I wasn't too sure about setting this default because it may potentially change behaviour... e.g. a French site usually viewed on a browser configured to assume French by default will now be forced to assume English.

What do you think?

chrisrhymes commented 3 years ago

That's a very good point!