search

chrisribe / ti-firebase

Appcelerator / Titanium module project to build and use the google firebase SDK
Other
33 stars 14 forks source link

signOut error case crash #2

Closed chrisribe closed 8 years ago

chrisribe commented 8 years ago

I set the code in the signOut method to only return a simple error string. The generated NSError seems to crash my app if I do anything with it.

https://github.com/chrisribe/ti-firebase/blob/master/iphone/Classes/TiFirebaseModule.m#L248

hansemannn commented 8 years ago

Fixed as part of https://github.com/chrisribe/ti-firebase/pull/6

chrisribe commented 8 years ago

The error still occurs, I tried to debug the issue. But as soon as I touch the error var the app crashes, "objc_msgSend".

Commented the callback code in master and replaced with error string.

chrisribe commented 8 years ago

Ok found code snip on the web and now using bool result and not crashing. https://github.com/chrisribe/ti-firebase/blob/master/iphone/Classes/TiFirebaseAuthModule.m#L128

Cannot seem to cause and error signOut always succeeds so, marking as fixed for now.