search

chrisroadmap / ar6

Figure and data generation for Chapter 7 of the IPCC's Sixth Assessment Report, Working Group 1 (plus assorted other contributions)
MIT License
33 stars 27 forks source link

Missing anthropogenic forcing definition in 245 #40

Open rguilcas opened 2 years ago

rguilcas commented 2 years ago

In Notebook 245, the anthropogenic part of the forcing is missing in the forcing[scenario] dictionaries. Probably missing something like the total forcing:

for scenario in scenarios: forcing[scenario]['total'] = ( forcing[scenario]['co2'] + forcing[scenario]['ch4'] + forcing[scenario]['n2o'] + forcing[scenario]['other_wmghg'] + forcing[scenario]['o3'] + forcing[scenario]['h2o_stratospheric'] + forcing[scenario]['contrails'] + forcing[scenario]['aerosol-radiation_interactions'] + forcing[scenario]['aerosol-cloud_interactions'] + forcing[scenario]['bc_on_snow'] + forcing[scenario]['land_use'] + forcing[scenario]['solar'] + forcing[scenario]['volcanic'] )

chrisroadmap commented 2 years ago

Hey, did you solve this in the end or is this still an issue?

rguilcas commented 2 years ago

Hey! This is still an issue in your notebook. I solved it by adding a similar block to the total forcing without volcanoes and solar forcing:

for scenario in scenarios: forcing[scenario]['anthro'] = ( forcing[scenario]['co2'] + forcing[scenario]['ch4'] + forcing[scenario]['n2o'] + forcing[scenario]['other_wmghg'] + forcing[scenario]['o3'] + forcing[scenario]['h2o_stratospheric'] + forcing[scenario]['contrails'] + forcing[scenario]['aerosol-radiation_interactions'] + forcing[scenario]['aerosol-cloud_interactions'] + forcing[scenario]['bc_on_snow'] + forcing[scenario]['land_use'] )

chrisroadmap commented 2 years ago

Cool, if you want to make a pull request with the right changes in the notebook I can run it and merge it in if it works

rguilcas commented 2 years ago

Ok, I will try ! Not so sure how to do it, but tell me if it works!