search

chrisroberts / krakow

Ruby client library for NSQ
Other
99 stars 17 forks source link

Make snappy gem optional #15

Closed grantr closed 10 years ago

grantr commented 10 years ago

The snappy gem uses a C extension which might not compile on all platforms. Since snappy compression is an optional feature, the gem should be optional as well. Enabling the feature should raise if the snappy gem is not present.

chrisroberts commented 10 years ago

:+1:

chrisroberts commented 10 years ago

These two commits should take care of it:

https://github.com/chrisroberts/krakow/commit/838e8b219be236246c91ab860a8f18a97ccf2e52 https://github.com/chrisroberts/krakow/commit/fae45fe5c25ee886e844e382f8592c5104658c6f

Will probably look at moving this out to a separate gem (krakow-snappy) so it can be isolated with its own deps.

grantr commented 10 years ago

Thanks @chrisroberts!