search

chrisroberts / vagabond

Advocating idleness and work-shyness
Other
233 stars 25 forks source link

vagabond server upload_roles does not account for JSON role files #27

Closed jaypipes closed 11 years ago

jaypipes commented 11 years ago

Hi Chris,

I think in fixing the issue where README or other txt files were causing upload_roles to die, you accidentally caused a bug :)

Getting this now with develop HEAD:

jpipes@uberbox:~/repos/att-cloud/chef-repo$ bundle exec vagabond server upload_roles
[sudo] password for jpipes: 
Local chef server: Uploading roles
Vagabond exiting. Reason: Expected process to exit with [0], but received '1'
---- Begin output of knife role from file /home/jpipes/repos/att-cloud/chef-repo/roles/*.rb  --server-url https://10.0.3.34 ----
STDOUT: 
STDERR: ERROR: Could not find or open file '/home/jpipes/repos/att-cloud/chef-repo/roles/*.rb' in current directory or in 'roles//home/jpipes/repos/att-cloud/chef-repo/roles/*.rb'
---- End output of knife role from file /home/jpipes/repos/att-cloud/chef-repo/roles/*.rb  --server-url https://10.0.3.34 ----
Ran knife role from file /home/jpipes/repos/att-cloud/chef-repo/roles/*.rb  --server-url https://10.0.3.34 returned 1

I believe this just needs to change to account for .rb and .json role files.

alff commented 11 years ago

Confirm this.

chrisroberts commented 11 years ago

Fix from @jaypipes applied (#28)