chrisschmitz / commandbox-hostupdater

9 stars 12 forks source link

Sudo / sed issue on mac #16

Open iknowkungfoo opened 6 years ago

iknowkungfoo commented 6 years ago

macOS High Sierra 10.13.3

I uninstalled my git repo fork of host updater and installed the latest from ForgeBox (1.7.1). I ran sudo box to start CommandBox and then server start, but CB is unable to update my hosts file:

CommandBox:go> server start
sed: 1: "/private/etc/hosts": invalid command code e

Oh my! Something went wrong when trying to modify the hosts file!
Adding host 'portal.localsite' to your hosts file!

Trying to load the server on port 80, so I understood that sudo was still needed. Am I missing something?

Found this post describing differences with sed between Linux and macOS.

bdw429s commented 2 years ago

Hi @iknowkungfoo , Ortus has taken over maintenance of this module in this new repo https://github.com/commandbox-modules/commandbox-hostupdater

Is this still an issue, and if so, can you submit a pull request to fix it? The error looks like your sed command is different, but I know there are people using this module on mac, so perhaps your specific version of Mac is related?

iknowkungfoo commented 2 years ago

Wow, this was what, 3-4 years ago? I'm on a different MBP now and the latest macOS. I'd say close this issue.

On Tue, May 24, 2022 at 4:39 PM Brad Wood @.***> wrote:

Hi @iknowkungfoo https://github.com/iknowkungfoo , Ortus has taken over maintenance of this module in this new repo https://github.com/commandbox-modules/commandbox-hostupdater

Is this still an issue, and if so, can you submit a pull request to fix it? The error looks like your sed command is different, but I know there are people using this module on mac, so perhaps your specific version of Mac is related?

— Reply to this email directly, view it on GitHub https://github.com/chrisschmitz/commandbox-hostupdater/issues/16#issuecomment-1136457161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFK6YGU7Y45VKDNHTXKUB3VLVEAHANCNFSM4EYHMA7A . You are receiving this because you were mentioned.Message ID: @.***>

-- Adrian J. Moreno

bdw429s commented 2 years ago

Thanks for the followup. I was just going through all the open tickets to ensure everything got brought over to the new repo.