chrissimpkins / codeface

Typefaces for source code beautification
Other
6.15k stars 416 forks source link

add missing fonts #142

Closed braver closed 6 years ago

braver commented 8 years ago

Adds

I don't have license files for Fifteen and Quinze but they're SIL OFL: https://fontlibrary.org/en/font/fifteen

(I standardized all file names in my repositories to make them easier to work with.)

chrissimpkins commented 8 years ago

Thanks for all of these contributions @braver. I will have a look and get them merged. Will be in touch with any questions.

chrissimpkins commented 8 years ago

Responded to your email by the way. Let me know if you have any more information about how you would like to collaborate.

chrissimpkins commented 8 years ago

Converting to an automated image generation approach that I hope to have implemented in the next week'ish. Sorry for the delay. I will get these merged as soon as it is available.

chrissimpkins commented 8 years ago

New gallery images are now merged. I will add these fonts over the weekend. Thanks @braver

chrissimpkins commented 8 years ago

Do you mind pulling Unifont out of your PR Koen? It is too large of a fileset to include in this collection.

If you'd like to include it in the CJK gallery, please submit as a separate pull request with the fonts in the cjk-fonts directory.

Thanks much.

braver commented 8 years ago

Sure, no problem. It is quite large (which is what you get for bitmap fonts I guess). It's a pretty cool project though, so perhaps the omission should be noted somewhere in the docs?

chrissimpkins commented 8 years ago

Sure, I will specify some inclusion criteria. Trying to keep archive file size as small as we can.

chrissimpkins commented 8 years ago

Are any others in this set bitmaps?

braver commented 8 years ago

No, I don't think so.

chrissimpkins commented 8 years ago

thanks!

chrissimpkins commented 8 years ago

Any chance that you would be willing to split these fonts into individual PR's? I will likely cherry pick a bit here and am ready to start including some.

braver commented 8 years ago

You could also just clone this branch somewhere and copy the files you want to your master clone. I don't really care enough about getting my name in your git history to spend all night splitting this into separate PR's :wink:

chrissimpkins commented 8 years ago

Thanks

chrissimpkins commented 8 years ago

I don't use the git commit history to acknowledge contributors in this project in any case. Your name is already on our contributors list.

braver commented 8 years ago

Ok, thanks. I just don't look forward to the hassle with git and everything to split out this PR. So, if you can manage it like this, that'd be easiest. If you need help, let me know.

chrissimpkins commented 8 years ago

It’s no problem, I can definitely do it.

chrissimpkins commented 8 years ago

The license that you included for Generic Mono does not appear to be for the correct set of fonts.

https://github.com/chrissimpkins/codeface/blob/master/fonts/generic/license.txt

Do you have a link to the site where this is released? I can access this via the link on your site but I don't find a release on the sites linked from that site.

Generic Mono II is now part of the collection.

braver commented 8 years ago

I think I originally got it from fontlibrary.org, but that site doesn't have this font anymore.

chrissimpkins commented 8 years ago

OK, thanks Koen.