search

chrissimpkins / crypto

Simple symmetric GPG file encryption and decryption
http://chrissimpkins.github.io/crypto
MIT License
48 stars 27 forks source link

adding --untar option to decrypto #9

Closed chrisidefix closed 9 years ago

chrisidefix commented 9 years ago

I am not 100% confident about the extraction in sub-directories. I tested it and it works the way it is now, but maybe we should run some proper test scenarios for this one.

chrissimpkins commented 9 years ago

merging this weekend. thanks for all of your efforts on this!

chrisidefix commented 9 years ago

no worries - I enjoy using it, too!

chrissimpkins commented 9 years ago

Apologize for the delay in getting to this. Tests are nearly complete for the --tar flag and will start on this. I think we should eliminate the optional approach and make this the default for any tar archives that are encountered following decryption.

chrisidefix commented 9 years ago

Generally, I agree that it should be the default to untar, but I would then suggest to add an explicit option to allow users not to untar files after decryption (e.g. --no-untar)?

chrissimpkins commented 9 years ago

merged with a new --nountar flag using default untar for decrypted tar archives and the optional flag to remove this default.

have some work to do on the directory structure of the unpacked files when they are not unpacked into the working directory and for the way that directories packed inside of tar archives are handled. starting work on that in development branch.

chrissimpkins commented 9 years ago

seems to be working. you can pull the current development branch to give it a try. will be adding tests.

chrisidefix commented 9 years ago

Great, I'll have a look at it soon.

chrissimpkins commented 9 years ago

I really like this. It's a great addition.

chrissimpkins commented 9 years ago

do you have an account that you would prefer me to link on the contributors list? Twitter? Your github account? If you are willing to share your name I would like to acknowledge your efforts when I announce this release.

chrisidefix commented 9 years ago

Thanks Chris, I'll send you an e-mail to the address linked on your profile.

chrissimpkins commented 9 years ago

Sounds great

chrissimpkins commented 9 years ago

got your email. thanks much.

tests are all passing and I think we are ready to push this release. will finish docs tomorrow and push to pypi.

let me know if you have any thoughts or additional suggestions.

chrisidefix commented 9 years ago

Yes, looks good to me from what I have seen. I guess what is left is the documentation. settings.py and README.md should probably include the new options. I would also suggest to add a comment in there somewhere that the extracted archive is being delete after untar completed.

chrissimpkins commented 9 years ago

sounds good. hope to push later today.

chrissimpkins commented 9 years ago

Released on PyPI. Thanks for all of your efforts on this release. It looks great.