Closed chrisidefix closed 9 years ago
merging this weekend. thanks for all of your efforts on this!
no worries - I enjoy using it, too!
Apologize for the delay in getting to this. Tests are nearly complete for the --tar
flag and will start on this. I think we should eliminate the optional approach and make this the default for any tar archives that are encountered following decryption.
Generally, I agree that it should be the default to untar, but I would then suggest to add an explicit option to allow users not to untar files after decryption (e.g. --no-untar)?
merged with a new --nountar
flag using default untar for decrypted tar archives and the optional flag to remove this default.
have some work to do on the directory structure of the unpacked files when they are not unpacked into the working directory and for the way that directories packed inside of tar archives are handled. starting work on that in development branch.
seems to be working. you can pull the current development branch to give it a try. will be adding tests.
Great, I'll have a look at it soon.
I really like this. It's a great addition.
do you have an account that you would prefer me to link on the contributors list? Twitter? Your github account? If you are willing to share your name I would like to acknowledge your efforts when I announce this release.
Thanks Chris, I'll send you an e-mail to the address linked on your profile.
Sounds great
got your email. thanks much.
tests are all passing and I think we are ready to push this release. will finish docs tomorrow and push to pypi.
let me know if you have any thoughts or additional suggestions.
Yes, looks good to me from what I have seen. I guess what is left is the documentation. settings.py
and README.md
should probably include the new options. I would also suggest to add a comment in there somewhere that the extracted archive is being delete after untar completed.
sounds good. hope to push later today.
Released on PyPI. Thanks for all of your efforts on this release. It looks great.
I am not 100% confident about the extraction in sub-directories. I tested it and it works the way it is now, but maybe we should run some proper test scenarios for this one.