chrisspen / gears

OpenSCAD gear generator.
Other
290 stars 68 forks source link

Everything should work this time #7

Closed keithemery closed 4 years ago

keithemery commented 4 years ago

I've added two modules to generate fixture holes for both standard and herringbone racks. Fixture holes can be generated to accommodate all standard ISO machine screws, except for cheese head. Cheese head screws were not included as they make little sense in this application, they will however fit within a standard pan head fixture hole.

chrisspen commented 4 years ago

Thanks for the contribution. Could you resolve the conflicts?

keithemery commented 4 years ago

After some months of much hair pulling, trying to figure out what I broke. I discovered a button that said 'mark as resolved'. All examples appear to work fine, including the two unmarked bug that I found in the process.

Should I fix those now or on the next pull?

chrisspen commented 4 years ago

Should I fix those now or on the next pull?

I'm not sure what you're talking about. What bugs?