christerdk / Malmofestivalen-for-Android

This is the home of the community driven Android app for Malmöfestivalen.

5 stars 1 forks source link

Feature 1 #5

Closed mirontoli closed 12 years ago

mirontoli commented 12 years ago

This is code for feature 1: getting small images in lists when available. It uses ImageDownloader which is described on the android blog. The image downloader uses cache for performance.

screencap

Some improvements can be made:

a default image for images which are beeing downloaded or, if they not exist (for now it is a question mark image).
...

christerdk commented 12 years ago

I've pulled down the code and tried to compile. This line gives me a compile error (in EventCursorAdapter):

ImageView iv = (ImageView) row.findViewById(R.id.eventitemrowimage);

Could it be that changes to eventitemrow.xml (or some other layout) did not get included in this pull request?

mirontoli commented 12 years ago

Yes. I missed to commit eventitemrow.xml. I'll do it soon.

christerdk commented 12 years ago

Sure, no problem. Enjoy the Sunday, we're not that busy :)

On 22/04/2012, at 09.28, Anatoly Mironov reply@reply.github.com wrote:

Yes. I missed to commit eventitemrow.xml. I'll do it soon.

Reply to this email directly or view it on GitHub: https://github.com/christerdk/Malmofestivalen-for-Android/pull/5#issuecomment-5266084

christerdk commented 12 years ago

Really nice job!

A couple of suggestions that I think I will go forward with is switching to async download (the performance is crippled a a bit by sync download), increasing the amount of objects in the cache (now 10), and also the purge time (now only 10 sec). I'll switch these things in my feature_1 branch and then merge to master, and then we'll take any follow bugs from there.

Once again, nice job!

mirontoli commented 12 years ago

Thank you. It was fun to write some code for android again. It was a while since the last time. I agree there are some improvement that can be made, and we will do them. The imageDownloader was a nice class which surely can be used on other activities.

christerdk commented 12 years ago

Absolutely. It could simplify the details view..

christerdk commented 12 years ago

We have an observation with regards to download of pictures. Is this something you could look into?

https://github.com/christerdk/Malmofestivalen-for-Android/issues/7

mirontoli commented 12 years ago

I'll look att it in the weekend.