search

christgau / wsdd

A Web Service Discovery host daemon.
MIT License
808 stars 97 forks source link

Fix and improve the Arch Linux installation instructions. #202

Closed fryfrog closed 1 week ago

fryfrog commented 3 months ago

I noticed the url for the Arch Linux aur package was wrong, so I went ahead and fixed it and added some hints about installing it too.

Hellscaped commented 2 weeks ago

sign your commits

fryfrog commented 2 weeks ago

I have to admit, I don't know how to do that and won't be able to dedicate time to that for a few weeks. I have no need to be the actual commit author, feel free to not literally use this PR if it helps. Otherwise, I'll revisit in the future.

christgau commented 1 week ago

sign your commits

While I do appreciate signed commits, contributions to this repo were and will be accepted (exceptions may apply) also without being singed. There is also no such requirement listed in the contribution guidelines in this repo. Given that background, this comment, IMHO, could have been formulated as a suggestion. In the way it has been formulated, it may also be considered as kind of rude.

I noticed the url for the Arch Linux aur package was wrong, so I went ahead and fixed it and added some hints about installing it too.

That being said, I wonder if this PR is actually still needed in its current form. It appears to me that wsdd has made it into Archs's official "extra" repo and it was removed from AUR, as far as I can see: https://aur.archlinux.org/packages/wsdd

IMO it should be changed such that one can simply install wsdd via pacman -Sy wsdd, or do I oversee something?

fryfrog commented 1 week ago

You’re totally right, it did get pulled into official after I did this. And a pacman example is the right call. I’ll close this.

Thanks!