search

christiaan / tinymce-codemirror

Development moved to gitlab.com/tinymce-plugins/tinymce-codemirror
https://gitlab.com/tinymce-plugins/tinymce-codemirror
Apache License 2.0
71 stars 29 forks source link

z-index issue with table panel and source code dialog #6

Closed Daijobou closed 8 years ago

Daijobou commented 8 years ago

In my tinymce 4.3.7 the table panel popup have a higher z-index than the source code dialog z-index.

See: https://picload.org/image/wpggcoc/zindexxt.png

Result: table panel is over source code dialog visible.

That problem comes with external_plugins: { "codemirror": "path/plugins/codemirror-1.4/plugin.min.js" },

thomich commented 8 years ago

same problem with latest tinymce 4.4.1 and codemirror plugin...

seams, table panel should be closed before opening codemirror dialog.. if using default code plugin in tinymce it works...

Daijobou commented 8 years ago

Yes, something like https://www.tinymce.com/docs/api/tinymce.ui/tinymce.ui.floatpanel/#hideall tinymce.ui.FloatPanel.hideAll();

This not work for me, after add in this line https://github.com/christiaan/tinymce-codemirror/blob/master/plugins/codemirror/source.html#L126 the FloatPanel is still not closed.

EDIT: I found a workaround. instead add this lines: tinymce.each(editor.contextToolbars, function(toolbar) { if (toolbar.panel) { toolbar.panel.hide(); } }); After open souce-editor the FloatPanel now disappear.

thomich commented 8 years ago

also added the line provided by @Daijobou into source.html before line 126 and it works now...

selection_013

hope someone of the tinymce-codemirror team will fix this issue, so we have latest version..

many thanks

christiaan commented 8 years ago

If you could create a pullrequest with this change I'd be happy to merge it.

thomich commented 8 years ago

this issue can be closed, right?

WebVeteran commented 8 years ago

Yeah this looks good to me. Opening the source closes other panels. There might be a better fix though. If you open a menu and then click source, those menus close immediately. The panels however, with this fix, only close after the source is loaded. It would better to put the panel closer function before opening the source view.

thomich commented 8 years ago

closing this issue.. if we find better solution, lets open a PR, check and merge it ;)