search

christian-korneck / get_win8key

script to read the Windows 8.x OEM license key from PC firmware
189 stars 43 forks source link

Add linux support #5

Open aeruder opened 9 years ago

aeruder commented 9 years ago

A couple cleanup commits followed by moving acpi functions into a module and then the small addition needed to add Linux support. Exe compiled on Windows 7 32-bit -- tested on Windows 8 64-bit and Arch Linux 64-bit.

aeruder commented 9 years ago

I had contemplated if it still made sense to include the compiled executable for Windows in the git repository as opposed to doing a separate build/release (I believe github has some mechanism for storing release files separate from the git repo). Mostly because it already takes a few minutes to clone the repository on my slow work connection.

christian-korneck commented 9 years ago

I had contemplated if it still made sense to include the compiled executable for Windows in the git repository

I agree, this was bad practice in the first place. But when I look at the repo's traffic stats, I can see many URLs with "download" links pointing to the raw get_win8key.exe in the trunk. The only reason why the compiled .exe is still in the trunk is to not break these links.

aeruder commented 9 years ago

That makes sense. Well, if the rest of this looks good, I'll just update the pull request to not update the .exe (especially not on every commit) as windows functionality is unchanged. Let me know, didn't know if Linux support really fit into your master plan so I will wait to hear from you before I update the pull request.