search

christian-marie / oauth2-server

Haskell libraries for implementing OAuth2 servers.
Other
24 stars 7 forks source link

Cleanup little bits of code, consolidate others. #132

Closed oswynb closed 9 years ago

oswynb commented 9 years ago

Completed a TODO and made code surrounding it more concise. Fixed a few minor typos/grammar/layout things.

thsutton commented 9 years ago

It makes sense to me that we have a throwInvalidScope helper here too. Other than that LGTM, so merge with or without the change.

christian-marie commented 9 years ago

This is a little ugly now, @thsutton had an idea to split this up a little. I don't see why checkClientAuthCode should return a (return ()). That's pretty bizarre and spaghetti-like in terms of control flow.

christian-marie commented 9 years ago

That said, the behaviour is improved and thus merge.