christian-posta / istio-workshop

145 stars 57 forks source link

Need to update the istio installation section for istio-0.4.0+ #16

Closed starksm64 closed 6 years ago

starksm64 commented 6 years ago

I was taking a look at the slides and when I compared the istio installation section to the current istio-0.4.0 release, the structure of the install directory has completely changed. The components directory and none of the istio-ca.yaml, istio-ingress.yaml, istio-mixer.yaml, istio-namespace.yaml, istio-pilot.yaml shown exist in this version.

The corresponding config now seems to be in the install/kubernetes/istio.yaml file.

christian-posta commented 6 years ago

Hey @starksm64 thanks for taking a look.

You're right, the stock installation comes with an all-in-one yaml for installation. For the workshop here, I've manually broken them down (this was done for the 0.3 release) for the purposes of illustrating what's exactly in each one.

Istio has some tools in upstream/master that allows us to generate the component files (or at least part of a PR i'm trying to get in upstream) and the community is also going in the direction of helm to help with this. See my issue here and PR here:

https://github.com/istio/istio/issues/2619

https://github.com/istio/istio/pull/2620

Once I have that PR in, i'll update to the latest resource component files (and/or update to use Helm).

Any thoughts?

starksm64 commented 6 years ago

Ok, I see. It would just be fine to indicate that the various component files were extracted from the istio.yaml file and that these can be generated via istioctl in the future just to let the user understand why they don't exist in the current fresh istio download.

christian-posta commented 6 years ago

Yah agreed. I'm waiting for the istioctl gen-deploy stuff to stabilize and release in an official istio release and i'll rework the installation stuff. Until then I can add a comment about those being extracted. Think it would be best on this slide? http://blog.christianposta.com/istio-workshop/slides/#/76

On Wed, Jan 17, 2018 at 4:52 PM, Scott M Stark notifications@github.com wrote:

Ok, I see. It would just be fine to indicate that the various component files were extracted from the istio.yaml file and that these can be generated via istioctl in the future just to let the user understand why they don't exist in the current fresh istio download.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/christian-posta/istio-workshop/issues/16#issuecomment-358489379, or mute the thread https://github.com/notifications/unsubscribe-auth/AADP0WOs71uLas_o68Lcnx04WKS7kRIDks5tLofRgaJpZM4RgyZy .

-- Christian Posta twitter: @christianposta http://blog.christianposta.com http://www.christianposta.com/blog

starksm64 commented 6 years ago

Yes, on that slide describe the creation of the $BASE/istio/install/components directory which does not exist in the official download and then the rest makes sense.

christian-posta commented 6 years ago

fixed with https://github.com/christian-posta/istio-workshop/commit/fa714cfa58683f202a4d94b94c59b4d4f576966b?diff=unified