search

christian-posta / openshift-terraform-ansible

Automate provisioning of OpenShift Origin/Enterprise with infrastructure as code
47 stars 41 forks source link

Remove unsupported terraform concat function #4

Closed oveits closed 7 years ago

oveits commented 8 years ago

I have found following closed terraform issue #6792 that is telling us that concat is not supported for strings anymore. Therefore, I propose to change 

Name = "${concat("node", count.index)}"

by the simpler expression

Name = "node${count.index}"

which works fine on my fork...

oveits commented 8 years ago

Github handling error, sorry: I thought that my pull request has opened issue #4, but it is not listed, when I search for "is:issue is:open". Therefore, I had to reopen this issue.

christian-posta commented 8 years ago

Awesome, thank you for this!

On Fri, Oct 14, 2016 at 8:17 AM, Oliver Veits notifications@github.com wrote:

Github handling error, sorry: I thought that my pull request has opened issue #4 https://github.com/christian-posta/openshift-terraform-ansible/pull/4, but it is not listed, when I search for "is:issue is:open". Therefore, I had to reopen this issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/christian-posta/openshift-terraform-ansible/pull/4#issuecomment-253831492, or mute the thread https://github.com/notifications/unsubscribe-auth/AADP0UpWh_0o3mpM3PmjA4Lu7QM7z4Zgks5qz50GgaJpZM4KXHeA .

Christian Posta twitter: @christianposta http://www.christianposta.com/blog http://fabric8.io

ioggstream commented 7 years ago

@christian-posta news? Is this repo still under development? Thx+Peace,R