christian-putzke / Roundcube-CardDAV

Roundcube CardDAV Plugin
http://www.graviox.de
GNU Affero General Public License v3.0
119 stars 28 forks source link

Seems not working with roundcube 1.0.0 #75

Open earendilfr opened 10 years ago

earendilfr commented 10 years ago

With the new version of roundcube, it's seems not work anymore. No error message but no contacts are seen on the address-book.

Roundcube : 1.0.0 Roundcube-carddav: v0.5.1

ghost commented 10 years ago

Hello, same issue.

I use Baïkal, working perfectly with iPhone but not with the RoundCube plugin. Error is probably because of PgSQL with affected_rows().

[08-Apr-2014 09:57:03 +0200]: v0.5.1 |  carddav_server_id: 3 | Starting CardDAV-Addressbook synchronization
[08-Apr-2014 09:57:03 +0200]: v0.5.1 |  carddav_server_id: 3 | Connected to the CardDAV-Server http://localhost/card.php/addressbooks/tinyfunk/default/
[08-Apr-2014 09:57:03 +0200]: v0.5.1 |  carddav_server_id: 3 | Added CardDAV-Contact to the local database with the vCard id 13EA3750-75DD1924-848F074C
[08-Apr-2014 09:57:03 +0200]: v0.5.1 |  carddav_server_id: 3 | Couldn't delete CardDAV-Contact from the local database with the vCard id
[08-Apr-2014 09:57:03 +0200]: v0.5.1 |  carddav_server_id: 3 | Syncronization complete!
markuman commented 10 years ago

No problems here using Baikal 0.2.7 (sqlite setup) and Roundcube 1.0.0 (sqlite setup)

yonyonson commented 10 years ago

@markuman What is your URI to get access to cardDav? I am trying to set up sync in simular the same config (Roundcube 1.0.0 and Baïkal 0.2.7, both over mySQL) and there seems to be nothing sent at all (aceess logs on Baïkal side are not showing any requests). I will try to look further and figure out why there are no requests sent.

markuman commented 10 years ago
https://BAIKAL.URL/card.php/addressbooks/USERNAME/default
yonyonson commented 10 years ago

@markuman no reply and all quiet in httpd access logs :( will try figuring out what is the reason and will tell if and when that's clear.

yonyonson commented 10 years ago

@markuman ok, that was all my bad. Wrong password and error in cardDav URI was the reason there was no contact. Thanks for your help, fetching contacts as we speak.

asashi commented 10 years ago

I've more or less the same problem Roundcube 1.0.0 Roundcube-carddav: v0.5.1 the plugin gets contacts from ownlcoud 6.0.3 and works perfectly in roundcube 9.5.0, but in rc 1.0.0 it works partially, I can see all the contacts in the autocompletion list, but in the addressbook I can see only the "first page", say the first 50 contacts, when I click the arrow to got to 51-100 contacts the list is empty, and so on for the others.

the very same plugin in rc 9.5.0 work smootly

Finn10111 commented 10 years ago

With Roundcube 0.9.5 the plugin worked fine, after upgrading to Roundcube 1.0.0 the Carddav plugin isn't working anymore. I truncated the carddav tables in my database and tried to readd and resync the contacts, now I get the following error message in my PostgreSQL logs:

FEHLER:  Spalte »carddav_contacts.name« muss in der GROUP-BY-Klausel erscheinen oder in einer Aggregatfunktion verwendet werden bei Zeichen 122
ANWEISUNG:  SELECT COUNT(*) FROM carddav_contacts
                WHERE
                    user_id = '1'
                AND
                    carddav_server_id = '7'

                ORDER BY
                    name ASC

Sorry, the error message is in German, but look at the query, does it make sense at all? It seems like Roundcube changed their database layout and Roundcube can't handle the changes..

votacom commented 10 years ago

I have the same logs as @Finn10111 .

I have deleted all occurances of "ORDER BY name ASC" in carddav_addressbook.php, now listing of the contacts works. But the ordering no is obviously gone.

I think Roundcube's implementation of $rcmail->db->query has changed from 0.9 -> 1.0, causing the error.

a-sassermann commented 10 years ago

I think these are two diffenent issues, The first (could'nt delete card) is a bug in the syncronisation of the local db, the last is an error in the record counting method of rcube_db. Therse should be fixed in my pull request #77. I would be interested to hear if it works for you.