search

christianalfoni / cerebral-react-baobab

A Cerebral package with React and Baobab
MIT License
13 stars 1 forks source link

Allow batching of updates #14

Open saulshanabrook opened 9 years ago

saulshanabrook commented 9 years ago

I think we discussed this a bit earlier, but I am not clear how to do it.

I have one action that calls state.push and then state.set. Is it possible to allow batching? So that I can do too mutations then call commit?

christianalfoni commented 9 years ago

It is still a bit unclear exactly how V2 of Baobab will work. It is very important that you can synchronously change the state and then just grab it again, or you will get into problems when later actions needs to access what you changed previously. This is supposed to be default behaviour in Baobab V2.

The thing is that it did not work as expected. As I understand Mr. Baobab is that you will synchronously do the changes to the tree, but you still need to commit to actually make them part of a new tree. But this is a bit unclear. Now it commits on every state change, but will change to the optimal batching VS sync solution when V2 is ready :-)

saulshanabrook commented 9 years ago

Cool sounds good, I thought this was waiting on baobab, but just wanted to add an issue to make sure.