search

christianalfoni / flux-angular

Use the FLUX architecture with Angular JS
312 stars 50 forks source link

webpack2 report error #69

Closed mafeifan closed 7 years ago

mafeifan commented 7 years ago

Hi,

when I use webpack2 and require("flux-angular") I got the error Cannot assign to read only property 'exports' of object. the reason is here #https://github.com/webpack/webpack/issues/4039 mix import and module.exports. so I changed L223 module.exports = 'flux'; to export { flux } in flux-angular file and it is working `

jrust commented 7 years ago

Interesting. The release, which includes that module.exports line, is being produced with browserify (full command is in package.json). From the issue referenced it appears that maybe it can be solved by changing the babelify options, but I wasn't able to get it to take. If you're able to get it working let me know and I can update the deploy command.

jrust commented 7 years ago

Fixed by 52ea2ed7a98946a943cbbb89f89eb89d7effdbc3