search

christianalfoni / react-app-boilerplate

React application boilerplate
303 stars 80 forks source link

Removed unnecessary 'if' for dependencies array, removed jsx pragma, … #21

Closed felipethome closed 8 years ago

felipethome commented 8 years ago

Currently the project has the following code in the gulpfile: if (options.development) { ... if (!options.development) { dependencies.splice(dependencies.indexOf('react-addons'), 1); } }

that will not be executed.

The jsx pragma was removed from the react project and is causing some issues when running gulp.

Updated the project to use react-dom.

The browserify external function can receive an array as argument so there is no need for a forEach.

christianalfoni commented 8 years ago

Thanks a bunch, this should all be updated now :-)

felipethome commented 8 years ago

Hi Christian, thank you too! Any reason why you decided to keep this piece of code:

if (options.development) {
    if (!options.development) {
        dependencies.splice(dependencies.indexOf('react-addons-test-utils'), 1);
    }
}
christianalfoni commented 8 years ago

Ah, sorry, I got a merge conflict so just missed that! Should be fixed now :-)