search

christianalfoni / webpack-express-boilerplate

A boilerplate for running a Webpack workflow in Node express
MIT License
1.4k stars 292 forks source link

Add SCSS support. #52

Closed vladinator1000 closed 8 years ago

vladinator1000 commented 8 years ago

This should work, tested in dev mode, haven't tried production mode because I'm a noob...

Thank you for the awesome boilerplate Christian! This is actually my 1st proper pull request to an open-source project ^^ Big milestone for me :D

christianalfoni commented 8 years ago

Hi @savovs and thanks for taking the time for creating the pull request! :)

But I am sorry I can not bring it in because it would be a bit too opinionated. Not everybody wants to use SCSS.

If you want though, you could update the README with "how to add SCSS"? Rather explaining how to do it. That way we do not force it in the boilerplate? Hope this makes sense :)

Really sorry to deny your first pull request man, hope I am not discouraging you from making more!

vladinator1000 commented 8 years ago

No problem dude, I learned a lot from it!