christianbarkowsky / contao-tabcontrol

Contao Extension :: Tabcontrol
https://brkwsky.de/tabcontrol-contao
8 stars 4 forks source link

tabcontrolJS Hook #28

Closed reluem closed 5 years ago

reluem commented 6 years ago

how do I use the tabcontrolJS Hook? I tried referencing my custom JS file in my config.php, but I always get an array warning.

I don't even need any tabcontrol JS invoked, since it is already loaded within my TL_JAVASCRIPT on default.

thank you!

christianbarkowsky commented 5 years ago

Hey @reluem ... i have not used this hook for years. Hmmm, i have to see.

reluem commented 5 years ago

Hey, in the meantime I used a frontend hook to remove the JS. This works quite fine for me :)

Am 17.01.2019 um 17:41 schrieb Christian Barkowsky notifications@github.com:

Hey @reluem ... i have not used this hook for years. Hmmm, i have to see.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

christianbarkowsky commented 5 years ago

would you like to show me your own script? @reluem

reluem commented 5 years ago

Not fancy / following best practice in any way…

https://github.com/reluem/contao-UIkit/blob/eca36cf2a988ac753de65638c4ddeea94ceadd72/src/Resources/contao/classes/integrations/UIkitclassesHook.php#L70

I unset the JS from $GLOBALS in my Controller class using the parseTemplate Hook, which I‘m calling anyway for another integration.

This works fine, but probably there‘s a better solution ;)

Am 17.01.2019 um 19:42 schrieb Christian Barkowsky notifications@github.com:

would you like to show me your own script? @reluem

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

christianbarkowsky commented 5 years ago

Ok. Fine. Next i will build a jquery version.